Use option_args when running accessories in a new container #1739
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
option_argsto the command generated when runningkamal accessory exec <accessory_name> <command>. These same options are passed when launching the accessory container, which causes inconsistent behaviour.With this change now new ephemeral containers will be created with the same options as when the application is deployed. This is how
kamal app exec works too: https://github.com/basecamp/kamal/blob/main/lib/kamal/commands/app/execution.rb#L10-L24For example: