Fix attachToolbar race under Turbo navigation #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition when using custom toolbar with Turbo navigation
This PR fixes a race condition that occurs when
<lexxy-editor>is initialized before the custom<lexxy-toolbar>is upgraded as a Web Component during Turbo-driven navigation.Problem
When navigating with Turbo, DOM elements are inserted incrementally.
<lexxy-editor>often connects before the custom toolbar is upgraded, so:throws:
This interrupts editor initialization and prevents content from loading.
Related issue:
#458
What this PR changes
attachToolbar()no longer assumes thattoolbarElementis already a fully upgraded custom element.attempts to attach immediately (for full page loads),
but if
setEditoris not yet available, it waits for:and retries on the next animation frame.
toolbarattribute, Lexxy no longer creates a default toolbar.This prevents the duplicate-toolbar issue under Turbo navigation.
Result