-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Add China region connectivity support #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
n1203
commented
Dec 15, 2025
- Add GitHub repository cloning mirror support in boot.sh
- Add China-friendly keyserver fallbacks in install/preflight/pacman.sh
- Add China-friendly keyserver configuration in default/gpg/dirmngr.conf
- Add Arch Linux package mirror list for China (mirrorlist-china)
- Create INSTALL_CN.md installation documentation for Chinese users
- Update README.md with reference to China installation guide
- Update omarchy-refresh-pacman to support china option
- Add GitHub repository cloning mirror support in boot.sh - Add China-friendly keyserver fallbacks in install/preflight/pacman.sh - Add China-friendly keyserver configuration in default/gpg/dirmngr.conf - Add Arch Linux package mirror list for China (mirrorlist-china) - Create INSTALL_CN.md installation documentation for Chinese users - Update README.md with reference to China installation guide - Update omarchy-refresh-pacman to support china option
|
Just want to +1 this. |
|
Does this PR simply provide better connectivity or does it actually allow Omarchy to work in this region? I don't love the idea of adding region-specific optimization (especially if it only makes things faster), feels like adding one will require us to add other regions too. If this PR doesn't make it through, maybe the next step would be adding support to use a custom (3rd party source) set of mirrors and keyservers, maybe stored in a JSON file that can be kept up-to-date outside of the main repo. |
|
+1 |
Hi Andrew — this PR is about making installs actually work in mainland China, not just faster. The mirrors and keyserver fallbacks move pacman/GPG from frequent failure to reliable completion on common ISPs. To avoid region creep, I can refactor it to a generic, opt‑in mechanism that loads mirrors/keyservers from an external JSON manifest. Default stays global; CN (and future regions) live outside the main repo. Happy to adjust the PR accordingly. |
Also, my first run with the install script failed mid‑way in China—pretty frustrating—this PR addresses that failure mode. |
I think adjusting the PR to do this would be great. Maybe once the mechanism is implemented, you can provide the China mirrors/keyservers in a gist or in the description of the PR, but not in the actual code in the repo. Maybe we can add it to the documentation once the PR is merged. |
Sounds like a plan. I'll refactor the PR to implement the generic opt-in mechanism and ensure the specific CN mirrors are kept out of the source code. I'll provide the example config in the PR description or a Gist once the changes are pushed. |
|
鉴于这个还木有合并,如果我想在最新的镜像用这个变更,请问应该如何手动修改文件呢? |