Skip to content

fix: Add confirmation prompt for empty password in Windows VM setup #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n1203 wants to merge 1 commit into from
Closed

fix: Add confirmation prompt for empty password in Windows VM setup #3881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions bin/omarchy-windows-vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,25 @@ EOF
USERNAME="docker"
fi

PASSWORD=$(gum input --placeholder="Password (Press enter to use default: admin)" --password --header="Enter Windows password:")
if [ -z "$PASSWORD" ]; then
PASSWORD="admin"
PASSWORD_DISPLAY="(default)"
else
PASSWORD_DISPLAY="(user-defined)"
fi
# Password input with validation loop
while true; do
PASSWORD=$(gum input --placeholder="Enter password (leave empty to use default 'admin' with confirmation)" --password --header="Enter Windows password:")

if [ -z "$PASSWORD" ]; then
# If password is empty, ask user what they want to do
if gum confirm "Use default password 'admin'?"; then
PASSWORD="admin"
PASSWORD_DISPLAY="(default)"
break
else
# User wants to enter a password, loop again
continue
fi
else
PASSWORD_DISPLAY="(user-defined)"
break
fi
done

# Display configuration summary
gum style \
Expand Down