Apply omarchy-launch-browser incognito function to every firefox browser by auto detecting its base#4572
Open
Mrid22 wants to merge 2 commits intobasecamp:devfrom
Open
Apply omarchy-launch-browser incognito function to every firefox browser by auto detecting its base#4572Mrid22 wants to merge 2 commits intobasecamp:devfrom
Mrid22 wants to merge 2 commits intobasecamp:devfrom
Conversation
Mrid22
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified omarchy-launch-browser so now it checks if a browser is firefox based or not, it greps its flags for --MOZ_LOG which is a firefox (and firefox-based) exclusive flag not present in chromium browsers. This way we dont have to add the executable names of every firefox browser to the script (ie librewolf and waterfox which werent there and would have to be added mannually)