Fix dictation push-to-talk dropping stop event on early modifier release#4575
Open
jra3 wants to merge 2 commits intobasecamp:devfrom
Open
Fix dictation push-to-talk dropping stop event on early modifier release#4575jra3 wants to merge 2 commits intobasecamp:devfrom
jra3 wants to merge 2 commits intobasecamp:devfrom
Conversation
The binddr (release) for SUPER CTRL + X requires both modifiers to still be held when X is released. If SUPER or CTRL is released first, the stop event never fires and recording gets stuck. Use a submap instead: pressing SUPER+CTRL+X starts recording and enters a dictation submap where X release alone (no modifier requirement) stops recording and exits the submap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
This doesn't seem to be working for me. If I release X first, it doesn't stop recording. I have to manually push X again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binddr(release) forSUPER CTRL + Xrequires both modifiers to still be held when X is released. If you release Super or Ctrl before X, the modifier mask no longer matches — the stop event never fires and recording gets stuck.SUPER+CTRL+Xstarts recording and enters adictationsubmap where the release of X alone (no modifier requirement) stops recording and exits the submap. This makes key release order irrelevant.Test plan
Super+Ctrl+X, hold, release X first → recording stops (same as before)Super+Ctrl+X, hold, release Super first then X → recording stops (was broken)Super+Ctrl+X, hold, release Ctrl first then X → recording stops (was broken)🤖 Generated with Claude Code