Fix snapshot delete bug and improve script robustness#4623
Open
amussara wants to merge 1 commit intobasecamp:devfrom
Open
Fix snapshot delete bug and improve script robustness#4623amussara wants to merge 1 commit intobasecamp:devfrom
amussara wants to merge 1 commit intobasecamp:devfrom
Conversation
…across scripts - Fix omarchy-snapshot: delete command used undefined $config variable, now properly iterates all snapper configs. Extract get_snapper_configs() helper function and add unknown command handling. - Improve omarchy-font-set: refactor into discrete functions (validate_font, update_alacritty, update_kitty, update_ghostty, update_system_configs, restart_components) for better maintainability. Add set -e and suppress errors from pkill when terminal processes aren't running. - Improve omarchy-theme-install: add URL validation (validate_repo_url), theme name extraction (extract_theme_name), clone helper (clone_theme), and theme content validation (validate_theme_contents) that warns on missing colors.toml. - Improve omarchy-webapp-install: add URL validation (validate_url), app name sanitization (sanitize_app_name), icon download helper (download_icon) with proper error handling, and desktop entry creation function (create_desktop_entry). Validate local icon existence. - Improve omarchy-migrate: add progress tracking (count_pending_migrations), extract run_migration() function with better error messages, add gum availability check before prompting, and report completion summary. - Fix omarchy-install-dev-env: add missing deno and zig to usage string, add catch-all case for unknown environments.
Member
|
You're going to have to offer more information on a PR than that. Can't just dump a 400-line change without any context on what's being fixed or why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix in omarchy-snapshot delete command + refactored scripts with validation.