Add JRuby supoort by copy all binary exectuables on pure Ruby platform#38
Draft
ryudoawaru wants to merge 3 commits intobasecamp:mainfrom
Draft
Add JRuby supoort by copy all binary exectuables on pure Ruby platform#38ryudoawaru wants to merge 3 commits intobasecamp:mainfrom
ryudoawaru wants to merge 3 commits intobasecamp:mainfrom
Conversation
and choose correct platform for JRuby.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For JRuby users, I just mod following ruby files to make this gem can run in JRuby
exe/thrust: Use RbConfig to make sure what kind of dist binary should use.rakelib/package.rake: Package all dist binaries for pure Ruby platform.I make this PR just because I want to make some of my projects can transform between CRuby and JRuby, please let me know if there is any possible concerns.
Thanks,