Teach thruster to optionally not log requests#50
Merged
kevinmcconnell merged 2 commits intobasecamp:mainfrom Aug 4, 2025
Merged
Teach thruster to optionally not log requests#50kevinmcconnell merged 2 commits intobasecamp:mainfrom
kevinmcconnell merged 2 commits intobasecamp:mainfrom
Conversation
nyku
approved these changes
Dec 5, 2024
Contributor
Author
|
@kevinmcconnell friendly ping 😄 |
Adds an environment variable, $LOG_REQUESTS, that when set to a falsey value will not add the logging middleware to the HTTP handler, disabling request logs. Other logs, like the startup messages, are left alone. Closes basecamp#49.
kevinmcconnell
force-pushed
the
request-log-optional
branch
from
b739f25 to
287f283
Compare
Collaborator
|
This looks great @nogweii, thanks! (And sorry for the slow response!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an environment variable, $LOG_REQUESTS, that when set to a falsey value will not add the logging middleware to the HTTP handler, disabling request logs. Other logs, like the startup messages, are left alone.
Closes #49.