Skip to content

Update golang.org/x/net to address two CVEs#74

Merged
kevinmcconnell merged 1 commit intobasecamp:mainfrom
matthewbjones:fix/go-net-0.37.0
Apr 21, 2025
Merged

Update golang.org/x/net to address two CVEs#74
kevinmcconnell merged 1 commit intobasecamp:mainfrom
matthewbjones:fix/go-net-0.37.0

Conversation

@matthewbjones
Copy link
Contributor

@matthewbjones matthewbjones commented Mar 24, 2025

Addresses two CVEs in golang/net by upgrading to 0.39.0 (latest)

CVE-2025-22870 (4.4 score, fixed in 0.36.0)
Matching of hosts against proxy patterns can improperly treat an IPv6 zone ID as a hostname component. For example, when the NO_PROXY environment variable is set to "*.example.com", a request to "[::1%25.example.com]:80` will incorrectly match and not be proxied.

CVE-2025-22872 (5.3 score, fixed in 0.38.0)
The tokenizer incorrectly interprets tags with unquoted attribute values that end with a solidus character (/) as self-closing. When directly using Tokenizer, this can result in such tags incorrectly being marked as self-closing, and when using the Parse functions, this can result in content following such tags as being placed in the wrong scope during DOM construction, but only when tags are in foreign content (e.g. , , etc contexts).

Fixes Issue #73

@matthewbjones
Copy link
Contributor Author

Related to #71, but updates to latest version 0.37.0

@MattKitmanLabs
Copy link

@kevinmcconnell Any chance you could cut a release with the CVE fixes in?

Just wanted to ask politely.

@matthewbjones
Copy link
Contributor Author

@kevinmcconnell just wanted to touch base on addressing this CVE, and the already-merged-but-not-released CVE fix 5f38465

@matthewbjones matthewbjones changed the title Update golang.org/x/net to address CVE Update golang.org/x/net to address two CVEs Apr 21, 2025
@matthewbjones
Copy link
Contributor Author

@kevinmcconnell updated PR to address another CVE (CVE-2025-22872)

@kevinmcconnell
Copy link
Collaborator

Thanks @matthewbjones, I'll get this shipped!

@kevinmcconnell kevinmcconnell merged commit 3fa5013 into basecamp:main Apr 21, 2025
1 check passed
@matthewbjones
Copy link
Contributor Author

@kevinmcconnell I got one more CVE fix incoming

@kevinmcconnell
Copy link
Collaborator

@matthewbjones ah, I just shipped a new version before seeing that message! But I had also bumped the Go version to latest, so I think we're all good?

https://github.com/basecamp/thruster/tree/v0.1.13

@matthewbjones
Copy link
Contributor Author

@kevinmcconnell no worries, I see you've released thruster 0.1.13, I'm updating now and will have Docker Scout analyze the docker image and confirm all 4 CVEs from the last few weeks have been addressed via the various updates

@matthewbjones
Copy link
Contributor Author

@kevinmcconnell I can confirm that thruster 0.1.13 addresses the four CVEs:
CVE-2025-22871
CVE-2025-22872
CVE-2025-22870
CVE-2025-22869

Thanks for working with me to get those dependencies updated

@kevinmcconnell
Copy link
Collaborator

Great, thanks @matthewbjones. I appreciate your help with these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants