Replace panicking with raising a Python exception#57
Merged
baseplate-admin merged 2 commits intobaseplate-admin:masterfrom Feb 17, 2025
Merged
Replace panicking with raising a Python exception#57baseplate-admin merged 2 commits intobaseplate-admin:masterfrom
baseplate-admin merged 2 commits intobaseplate-admin:masterfrom
Conversation
dlozeve-pro
changed the title
Owner
|
Hey thank you for the PR, (i really appreciate it). |
baseplate-admin
merged commit ab68eff
into
baseplate-admin:master
14 of 15 checks passed
Owner
|
Released in v0.2.0 |
Contributor
Author
|
No problem, thank you for the library and the quick response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some parts of the code were panicking, which could crash the entire Python interpreter. A possible improvement could be to propagate these errors to Python, raising a
ValueErrorinstead.