Pin HuggingFace revisions in weights to commit SHAs on push#2164
Open
Pin HuggingFace revisions in weights to commit SHAs on push#2164
Conversation
- Add hf_revision_resolver utility to resolve HF revisions to SHAs - Modify BasetenRemote._prepare_push to pin unpinned HF revisions - Resolves 'main' and missing revisions to commit SHAs - Writes updated config.yaml with pinned revisions - Ensures reproducible deployments (same config = same weights) - Mirrors existing model_cache behavior but at push time - Adds comprehensive tests for revision resolution Fixes INF-2314
bolasim
force-pushed
the
01-27-pin_huggingface_revisions_in_weights_to_commit_shas_on_push
branch
from
3457f16 to
c5f6da3
Compare
michaelfeil
reviewed
Jan 28, 2026
| import re | ||
| from typing import Optional | ||
|
|
||
| from huggingface_hub import HfApi |
Contributor
There was a problem hiding this comment.
Bad, import of optional deps at global level. Move to inside resolve_hf_revision(
michaelfeil
reviewed
Jan 28, 2026
| resolve_hf_revision, | ||
| ) | ||
|
|
||
| config = truss_handle._spec._config |
Contributor
There was a problem hiding this comment.
now you're running the try except for every push. Not good. Only try when weights are used and huggingface is used and revision is main or startswith(refs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes INF-2314