Fix docker image list behavior for ITs#2231
Merged
Conversation
nnarayen
force-pushed
the
nikhil/fix-integration-tests
branch
from
2a06932 to
3261977
Compare
nnarayen
commented
Feb 13, 2026
| cache: yarn | ||
| cache-dependency-path: baseten-performance-client/node_bindings/yarn.lock | ||
| architecture: x86 | ||
| # We use `docker run` directly instead of a third-party action to avoid |
Contributor
Author
There was a problem hiding this comment.
cc @michaelfeil, I haven't fully investigated, but I think docker on GHA runners is slowly updating, and seems like this action bundled an incompatible cli version. This just uses the cli that comes with docker directly, since the action hasn't been updated in a while
nnarayen
force-pushed
the
nikhil/fix-integration-tests
branch
from
93ea686 to
155ac56
Compare
nnarayen
force-pushed
the
nikhil/fix-integration-tests
branch
from
155ac56 to
977fec3
Compare
ndeepak-baseten
approved these changes
Feb 13, 2026
Contributor
ndeepak-baseten
left a comment
ndeepak-baseten
left a comment
There was a problem hiding this comment.
Too bad the GHA doesn't allow us to pin docker. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
Context: https://basetenlabs.slack.com/archives/C0A6XLUS3NK/p1771010736066349
Theory is that the docker version in GHA recently updated to V29, which changed the default behavior of which images are exposed via
docker image ls.💻 How
🔬 Testing
IT run: https://github.com/basetenlabs/truss/actions/runs/22001631192