-
-
Notifications
You must be signed in to change notification settings - Fork 93
Update JSON schema to include command.variables
#564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@EmilyGraceSeville7cf, I have added a new possible value for It is an array of dictionaries, and each item must have a variables:
# Simple value
- name: output_folder
value: output
# Array
- name: download_sources
value:
- youtube
- instagram
# Associative array
- name: zip_options
value:
pattern: "*.json"
compression_level: fast So I did not limit the value to any particular type. Your approval por favor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just have some questions and comments 😄
Bash variables for the current application | ||
https://bashly.dannyb.co/configuration/command/#variables | ||
type: array | ||
uniqueItems: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add minItems: 1
. It is the matter of the answer to the following question: Should we remind the user that something is expected in an array of let it go (if an empty array is not an error in config)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added minItems: 1
and updated some other arrays that had minLength
instead of minItems
.
value: | ||
title: value | ||
description: A value for the current variable | ||
examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the variable value is null
? Is it an error? What it corresponds to in Bash (in the context of Bashly) if it's not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null
is allowed (it will be null if not provided), and the bash variable definition will simply be varname=""
.
Thanks @EmilyGraceSeville7cf - merging. |
Update schema for #563