Skip to content

Conversation

DannyBen
Copy link
Member

@DannyBen DannyBen commented Aug 30, 2025

As discussed in #665 and raised in #664.

This adds the ability to add _production or _development suffix to all option names in the settings.


@DannyBen DannyBen added this to the 1.3.3 milestone Aug 30, 2025
@DannyBen DannyBen requested a review from Copilot August 30, 2025 10:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for per-environment settings in Bashly, allowing users to specify environment-specific configuration values by appending _production or _development suffixes to option names in the settings file.

  • Refactored the settings retrieval logic to support environment-specific configuration overrides
  • Added comprehensive test coverage for the new environment suffix functionality
  • Updated documentation in the settings file to explain the new feature

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
lib/bashly/settings.rb Refactored settings retrieval logic to support environment-specific overrides with _production/_development suffixes
spec/bashly/settings_spec.rb Added test cases to verify environment suffix override behavior
lib/bashly/libraries/settings/settings.yml Enhanced documentation with detailed explanation of environment overrides feature
.rubocop.yml Added exception for longer test examples in command spec file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DannyBen DannyBen merged commit a29a2fc into master Aug 31, 2025
7 checks passed
@DannyBen DannyBen deleted the add/config-env-suffix branch August 31, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant