feat: add stable external_id (UUID) to Project and Entity models #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a stable external_id UUID field to both Project and Entity models for use in the v2 API. This provides immutable identifiers that won't change with renames or database migrations, improving API reliability and enabling better cross-system references. Changes: - Add external_id column to project and entity tables via migration - Add repository methods to query by external_id - Update v2 API routers to use external_id in URL paths - Add new FastAPI dependencies for external_id validation - Update schemas to expose external_id in responses - Update tests for new external_id-based API The external_id is automatically generated as a UUID v4 for new records and backfilled for existing records during migration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Joe P <[email protected]>
The down_revision field in merge migrations is a tuple of strings, not a single string. Updated type annotation to Union[str, Sequence[str], None]. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Joe P <[email protected]>
Signed-off-by: Paul Hernandez <[email protected]>
…dencies The v2 external importer dependencies (using external_id UUIDs) were missing the file_service parameter that was added to the Importer base class in a recent refactor. This caused TypeError when constructing importers via the v2 API endpoints. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: phernandez <[email protected]>
Windows has different process cleanup behavior that makes subprocess-based cleanup tests unreliable in CI. These tests validate Unix-style process cleanup which isn't applicable to Windows anyway. The tests continue to run on Linux and macOS where the behavior is consistent and meaningful. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: phernandez <[email protected]>
phernandez
force-pushed
the
feature/external-id-for-projects-and-entities
branch
from
ba40105 to
b2ba64a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
external_idUUID field to Project and Entity models for v2 APIChanges
Database
external_idcolumn toprojectandentitytablesModels
Project.external_id- UUID string, auto-generated on createEntity.external_id- UUID string, auto-generated on createAPI
ProjectExternalIdPathDep,EntityRepositoryV2ExternalDep, etc.Tests
Test plan
just test-unit-sqlitejust test-int-sqlitejust test-postgres🤖 Generated with Claude Code