Fix record iterator and __getitem__ methods #1030 (#1032)

Fixes #1030

Author: mitch-kyle

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
  * Fix a bug where the compiler would always generate inline function definitions even if the `inline-functions` compiler option is disabled (#1023)
  * Fix a bug where `defrecord`/`deftype` constructors could not be used in the type's methods. (#1025)
+ * Fix a bug where `keys` and `vals` would fail for records (#1030)
 
 ## [v0.2.1]
 ### Changed

src/basilisp/core.lpy

@@ -6869,9 +6869,9 @@
               (contains? ~'_recmap ~key-gs)
               (get ~'_recmap ~key-gs default#))))
          (~'__getitem__ [~this-gs ~key-gs]
-          (. ~this-gs ~'entry ~key-gs))
+          (.val-at ~this-gs ~key-gs))
          (~'__iter__ [~this-gs]
-          (seq ~this-gs))
+          (python/iter (map first (seq ~this-gs))))
          (~'__len__ [~this-gs]
           (+ ~(count field-kw-set)
              (count ~'_recmap)))

tests/basilisp/test_defrecord.lpy

@@ -73,6 +73,13 @@
              ((juxt :w :x :y :z :new-key) p2)))
       (is (= [1 nil 3] ((juxt :x :y :z) p3))))
 
+    (testing "__getitem__ field access"
+      (is (= 1 (.__getitem__ p :x)))
+      (is (= 2 (.__getitem__ p :y)))
+      (is (= 3 (.__getitem__ p :z)))
+      (is (nil? (.__getitem__ p :l)))
+      (is (= 0 (.__getitem__ p1 :w))))
+
     (testing "assoc"
       (is (= 4 (:x (assoc p :x 4))))
       (is (= 5 (:y (assoc p :y 5))))
@@ -150,6 +157,21 @@
       (is (= #{[:x 1] [:z 3]}
              (set (seq p3)))))
 
+    (testing "iterator"
+      (is (= #{:x :y :z} (set (seq (python/iter p)))))
+      (is (= #{:w :x :y :z} (set (seq (python/iter p1)))))
+      (is (= #{:w :x :y :z :new-key} (set (seq (python/iter p2))))))
+
+    (testing "keys"
+      (is (= #{:x :y :z} (set (keys p))))
+      (is (= #{:w :x :y :z} (set (keys p1))))
+      (is (= #{:w :x :y :z :new-key} (set (keys p2)))))
+
+    (testing "vals"
+      (is (= #{1 2 3} (set (vals p))))
+      (is (= #{0 1 2 3} (set (vals p1))))
+      (is (= #{0 1 2 3 "some-value"} (set (vals p2)))))
+
     (testing "equals"
       (is (= (->Point 1 2 3) p))
       (is (= p1