Apply :end-line and :end-col metadata to forms from the reader (#904)

Fixes #903

Author: chrisrink10

CHANGELOG.md

@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Added
+ * Added `:end-line` and `:end-col` metadata to forms during compilation (#903)
+
 ### Fixed
  * Fix a bug where `.` characters were not allowed in keyword names (#899)
  * Fix a bug where nested quotation marks were not escaped properly by various print functions and at the REPL (#894)

docs/cli.rst

@@ -50,11 +50,15 @@ You can then establish a connection from your IDE to the server address.
 
 - from `Emacs`, using `CIDER <https://github.com/clojure-emacs/cider>`_
 
-  `M-x cider-connect-clj`
+  .. code-block::
+
+     M-x cider-connect-clj
 
 - from `Visual Studio Code`, using `Calva <https://calva.io/>`_
 
-  `REPL` -> `Connect to a running REPL in your project` -> `Generic`
+  .. code-block::
+
+     REPL -> Connect to a running REPL in your project -> Generic
 
 .. _run_basilisp_code:
 

src/basilisp/lang/compiler/analyzer.py

@@ -50,6 +50,8 @@
     COL_KW,
     DEFAULT_COMPILER_FILE_PATH,
     DOC_KW,
+    END_COL_KW,
+    END_LINE_KW,
     FILE_KW,
     LINE_KW,
     NAME_KW,
@@ -951,8 +953,8 @@ def _def_ast(  # pylint: disable=too-many-locals,too-many-statements
     # is likely to have metadata. In rare cases, we may not be able to get
     # any metadata. This may happen if the form and name were both generated
     # programmatically.
-    def_loc = _loc(form) or _loc(name) or (None, None)
-    if def_loc == (None, None):
+    def_loc = _loc(form) or _loc(name) or (None, None, None, None)
+    if def_loc == (None, None, None, None):
         logger.warning(f"def line and column metadata not provided for Var {name}")
     if name.meta is None:
         logger.warning(f"def name symbol has no metadata for Var {name}")
@@ -963,8 +965,10 @@ def _def_ast(  # pylint: disable=too-many-locals,too-many-statements
             lmap.map(
                 {
                     COL_KW: def_loc[1],
+                    END_COL_KW: def_loc[3],
                     FILE_KW: def_node_env.file,
                     LINE_KW: def_loc[0],
+                    END_LINE_KW: def_loc[2],
                     NAME_KW: name,
                     NS_KW: current_ns,
                 }

src/basilisp/lang/compiler/constants.py

@@ -55,9 +55,11 @@ class SpecialForm:
 INTERFACE_KW = kw.keyword("interface")
 REST_KW = kw.keyword("rest")
 COL_KW = kw.keyword("col")
+END_COL_KW = kw.keyword("end-col")
 DOC_KW = kw.keyword("doc")
 FILE_KW = kw.keyword("file")
 LINE_KW = kw.keyword("line")
+END_LINE_KW = kw.keyword("end-line")
 NAME_KW = kw.keyword("name")
 NS_KW = kw.keyword("ns")