Support reloading namespaces #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
force-pushed
the
feature/reload-ns
branch
2 times, most recently
from
74ca790 to
60c1c5c
Compare
chrisrink10
force-pushed
the
feature/reload-ns
branch
from
99a86e0 to
913d188
Compare
chrisrink10
commented
Sep 18, 2024
Comment on lines
+389
to
+393
| if (cached := self._cache.get(fullname)) is None: | ||
| spec = module.__spec__ | ||
| assert spec is not None, "Module must have a spec" | ||
| cached = {"spec": spec} | ||
| self._cache[spec.name] = cached |
There was a problem hiding this comment.
I doubt this ever happens except in testing, but I was finding that calling monkeypatch.syspath_prepend that monkeypatch calls importlib.invalidate_caches() which was causing issues trying to access values from the cache without any guard. Now we just reconstruct the cache from the module if that does happen.
| ns_sym = sym.symbol(ns_name) | ||
| ns = self.get(ns_sym) | ||
| assert ns is not None, "Namespace must exist after being required" | ||
| self.add_alias(ns, ns_sym) |
There was a problem hiding this comment.
I think it was always my intent to add the fully-qualified name as an alias to the namespace, but it never mattered before now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1060