-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add support for Python 3.13; drop support for Python 3.8 #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99c4f02 to
3d07534
Compare
3d07534 to
8aa90ec
Compare
|
Hi @chrisrink10, apologies for the intrusion, MS-Windows failure below is due to python/cpython#125283 change in |
|
Something along the following fixes the break diff --git a/src/basilisp/io.lpy b/src/basilisp/io.lpy
index a07e861..9dca382 100644
--- a/src/basilisp/io.lpy
+++ b/src/basilisp/io.lpy
@@ -34,7 +34,7 @@
(let [path (.-path f)]
;; On MS-Windows, extracting an absolute path from the URL
;; incorrectly adds a leading `/', .e.g. /C:\xyz.
- (pathlib/Path #?(:windows (if (os.path/isabs path) (subs path 1) path)
+ (pathlib/Path #?(:windows (if (str/starts-with? path "/") (subs path 1) path)
:default path)))
(throw
(ex-info "Cannot coerce non-File URL to pathlib.Path"
|
|
@ikappaki thanks! I pushed that and will see how it goes. |
da93abd to
6fb0268
Compare
| report-coverage: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| try: | ||
| self._exec_cached_module(fullname, spec.loader_state, path_stats, ns) | ||
| except (EOFError, ImportError, IOError, OSError) as e: | ||
| except (EOFError, ImportError, OSError) as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1056
I ran
pyupgrade --py39-pluson the entire source tree to convert fromtyping.{List,Set,...}to the generic forms of the builtins (among other available upgrades).Upgrading to 3.13 also surfaced #1088 which I filed to address separately since this PR is already quite large.