Fix a bug where the reader was double counting the CRLF newline seq #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
reviewed
Sep 19, 2024
| @pytest.mark.parametrize( | ||
| "evalstr,first,second", | ||
| [ | ||
| ("[5]\n(def n 123)", (1, 1, 0, 3), (2, 2, 0, 11)), |
There was a problem hiding this comment.
Can you add cases for buffers starting with \n and \r\n as well since we're looking back in the last 2 characters?
There was a problem hiding this comment.
Added the following, is this what you had in mind?
("\n[5]\n(def n 123)", (2, 2, 0, 3), (3, 3, 0, 11)),
("\r[5]\r(def n 123)", (2, 2, 0, 3), (3, 3, 0, 11)),
("\r\n[5]\r\n(def n 123)", (2, 2, 0, 3), (3, 3, 0, 11)),
chrisrink10
approved these changes
Sep 19, 2024
chrisrink10
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you please a fix for the line number in the metadata generated by the reader. It fixes #1063.
We now check the char at -2 only if it’s:
\n(for\nCor\r\nCcase)\r(for the\rC, but not\r\n, case).where
Cis any other char.Added tests for the same.
Thanks