Fix basilisp test CLI command to pass remaining args to PyTest
#1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
commented
Nov 13, 2024
Comment on lines
+757
to
+771
| Any options not recognized by Basilisp and all positional arguments will | ||
| be collected and passed on to PyTest. It is possible to directly signal | ||
| the end of option processing using an explicit `--` as in: | ||
| `basilisp test -p other_dir -- -k vector` | ||
| This can be useful to also directly execute PyTest commands with Basilisp. | ||
| For instance, you can directly print the PyTest command-line help text using: | ||
| `basilisp test -- -h` | ||
| If all options are unambiguous (e.g. they are only either used by Basilisp | ||
| or by PyTest), then you can omit the `--`: | ||
| `basilisp test -k vector -p other_dir`""" |
There was a problem hiding this comment.
This also addresses the comment about documenting the -- behavior.
|
Thanks @chrisrink10 , it all seems to be working fine now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1119
@ikappaki I think this change will work now. I tried it on 3.11.7, 3.12.7, and 3.13.0 using the repository and makefile you prepared to test and each worked as expected.