Do not attempt to resolve symbols in data reader tags #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1129
For anyone who finds this PR (perhaps triaging a bug introduced by it in the future): I tried to ascertain exactly what Clojure JVM does in this situation and it is quite unclear in the reader code and not (at the time of writing) specified on any of the official documentation. Examples given there seem to indicate that fully qualified tags be given in
data_readers.cljcand thus symbol resolution should not be performed on them, but they don't say explicitly. CLJS#js []literals work as they do now in this PR so I'm going to assume this is the intended behavior.