Skip to content

Fix issue with time failing to expand with macroexpand-all #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix issue with time failing to expand with macroexpand-all #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Fix a bug where `keyword` and `symbol` functions did not treat string arguments as potentially namespaced (#1131)
* Fix a bug where `condp` would throw an exception if a result expression was `nil` (#1137)
* Fix a bug where integer division which resulted in an integer would return a `fractions.Fraction` (#1140)
* Fix a bug where `basilisp.core/time` would fail to expand with `macroexpand-all` in a nested macro call (#1143)

## [v0.3.2]
### Added
Expand Down
4 changes: 2 additions & 2 deletions src/basilisp/core.lpy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4078,11 +4078,11 @@
"Time the execution of ``expr``\\. Return the result of ``expr`` and print the time
execution took in milliseconds."
[expr]
`(let [start (perf-counter)]
`(let [start# (perf-counter)]
(try
(do ~expr)
(finally
(println (* 1000 (- (perf-counter) start)) "msecs")))))
(println (* 1000 (- (perf-counter) start#)) "msecs")))))

;;;;;;;;;;;;;;;;;;;;;;
;; Threading Macros ;;
Expand Down
Loading