Skip to content

Fix a bug where multi-arity defns could not be emitted by macros #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Fix a bug where multi-arity defns could not be emitted by macros #1164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82f20e1
Fix a bug where multi-arity `defn`s could not be emitted by macros
chrisrink10 Dec 5, 2024
3659bd4
Force 3.13.0
chrisrink10 Dec 5, 2024
952ecde
Ugh
chrisrink10 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
version: ['3.9', '3.10', '3.11', '3.12', '3.13']
version: ['3.9', '3.10', '3.11', '3.12', '3.13.0']
include:
- version: '3.9'
tox-env: py39,py39-mypy,py39-lint,bandit
Expand All @@ -26,7 +26,7 @@ jobs:
tox-env: py311,py311-mypy,py311-lint,bandit
- version: '3.12'
tox-env: py312,py312-mypy,py312-lint,format,bandit
- version: '3.13'
- version: '3.13.0'
tox-env: py313,py313-mypy,py313-lint,bandit
- os: windows-latest
version: '3.13'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Fix a bug where `condp` would throw an exception if a result expression was `nil` (#1137)
* Fix a bug where integer division which resulted in an integer would return a `fractions.Fraction` (#1140)
* Fix a bug where `basilisp.core/time` would fail to expand with `macroexpand-all` in a nested macro call (#1143)
* Fix a bug where `defn` and `defmacro` forms containing multiple arities could not be emitted by macros (#1163)

## [v0.3.2]
### Added
Expand Down
6 changes: 3 additions & 3 deletions src/basilisp/core.lpy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@
body (if fmeta
(rest body)
body)
multi? (list? (first body))
multi? (seq? (first body))
fsigs (if multi?
(loop [arities body
sigs []]
Expand Down Expand Up @@ -617,7 +617,7 @@
fname (if doc
(vary-meta name assoc :doc doc :macro true)
(vary-meta name assoc :macro true))
multi? (list? (first body))
multi? (seq? (first body))
fsigs (if multi?
(loop [arities body
sigs []]
Expand Down Expand Up @@ -6528,7 +6528,7 @@
(not (seq specs))
(assoc groups iface methods)

(list? (first specs))
(seq? (first specs))
(recur iface
(rest specs)
(conj methods (first specs))
Expand Down
Loading