Skip to content

return nil from import #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

return nil from import #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f1830
return nil from `import`
ikappaki Dec 13, 2024
5fa9ea2
move `do` in the eval'ed form
ikappaki Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
* `import` now returns nil instead of the last module's string representation (#1174)

## [v0.3.5]
### Changed
Expand Down
3 changes: 2 additions & 1 deletion src/basilisp/core.lpy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4936,7 +4936,8 @@
;; to the new ns, the global python namespace can still refer to the
;; old python global ns where the import would have been evaluated
;; otherwise.
(let [form `(import* ~@modules)]
(let [form `(do (import* ~@modules)
nil)]
`(eval '~form *ns*)))

(defn ^:private rewrite-clojure-libspec
Expand Down
Loading