Skip to content

Increase lower bound tolerance of future deref timeout test #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Increase lower bound tolerance of future deref timeout test #1185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c66d995
Increase lower bound tolerance of future deref timeout test
ikappaki Dec 19, 2024
75a638c
Merge branch 'main' into test/fut-timeout-telerance
chrisrink10 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/basilisp/test_core_fns.lpy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,7 @@
end (time/perf-counter)
diff (- end start)]
(is (= :timed-out ret))
(is (< 0.1 diff 0.5) (str "deref timeout is outside of [100ms, 500ms] range: " diff "ms")))))
(is (< 0.1 diff 0.5) (str "deref timeout is outside of [100ms, 500ms] range: " diff "s")))))

;;;;;;;;;;;;;
;; Futures ;;
Expand All @@ -1573,8 +1573,14 @@
end (time/perf-counter)
diff (- end start)]
(is (= :timed-out ret))
(is (< 0.1 diff 0.5) (str "deref timeout outside of [100ms, 500ms] range: " diff "ms"
" -- :pre " pre " :start " start " :end " end))
;; The lower bound is set to 95ms instead of 100ms due to an
;; unexplained discrepancy observed on GitHub CI, where `deref`
;; returned a few milliseconds before the time-out period
;; elapsed.
;;
;; https://github.com/basilisp-lang/basilisp/issues/1184
(is (< 0.095 diff 0.5) (str "deref timeout outside of [95ms, 500ms] range: " diff "s"
" -- :pre " pre " :start " start " :end " end))
(is (= false (future-cancelled? fut)))
(is (= false (future-done? fut)))
;; can't always cancel a sleep-ed Future
Expand Down
Loading