Fix defining async generators #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
commented
Apr 10, 2025
There was a problem hiding this comment.
Making FunctionContext type mutable so it can be changed during the analysis phase and older references to the same object remain valid.
The issue is that we could call AnalyzerContext.get_node_env() (which captures FunctionContext) before we know if a function is a generator. If the FunctionContext type is frozen and we have to replace the object (as by attr.assoc), the references in previous NodeEnvs would not be correct.
One downside of using a mutable type is that it is not hashable, so I had to suppress including NodeEnv from hash computations for nodes. This is not unlike the way a symbol's hash only depends on the name and namespace, not the attached metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180