Added aslice macro
#1249
Merged
Added aslice macro
#1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
reviewed
Apr 24, 2025
Comment on lines
+1981
to
+1984
| "Get a portion of the Python list ``array`` using a | ||
| Python :external:py:obj:`slice` instance with a single ``stop`` | ||
| value, or a combination of ``start`` and ``stop`` and optional | ||
| ``step`` values. |
There was a problem hiding this comment.
I'm wondering if we should add any documentation about the fact that nil is equivalent to omission in Python for any of these values.
There was a problem hiding this comment.
Updated, I've tried to mention nil means omit in the next paragraph, but please be free to suggest a better wording.
ikappaki
force-pushed
the
feature/aslice
branch
from
38ea78d to
87b2199
Compare
chrisrink10
approved these changes
Apr 24, 2025
Comment on lines
+1981
to
+1984
| "Get a portion of the Python list ``array`` using a | ||
| Python :external:py:obj:`slice` instance with a single ``stop`` | ||
| value, or a combination of ``start`` and ``stop`` and optional | ||
| ``step`` values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you please consider patch to introduce the
aslicemacro inbasilisp.core. It addresses #1248.Thanks