Open
Conversation
istvanfedak
approved these changes
Nov 2, 2025
skonves
commented
Nov 2, 2025
packages/express/src/spec/4.1-structure/4.1.24-http-method.spec.ts
Outdated
Show resolved
Hide resolved
skonves
commented
Nov 2, 2025
| } | ||
| closeHandler(); | ||
| } catch (err) { | ||
| closeHandler(); |
Member
Author
There was a problem hiding this comment.
We might want to consider moving closeHandler() to the finally block. Not sure it has to precede the call to next().
There was a problem hiding this comment.
I added it to the finally block. We would have to test it out with a real world example
skonves
commented
Nov 2, 2025
packages/express/src/spec/4.1-structure/4.1.24-http-method.spec.ts
Outdated
Show resolved
Hide resolved
istvanfedak
reviewed
Nov 2, 2025
|
|
||
| const stream = await service.streamWidgets(params); | ||
| for await (const event of stream) { | ||
| res.write(event); |
There was a problem hiding this comment.
Should we expect the service.streamWidgets(params); to handle returning the events formatted correctly for no validation?
istvanfedak
reviewed
Nov 2, 2025
packages/express/src/spec/4.1-structure/4.1.24-http-method.spec.ts
Outdated
Show resolved
Hide resolved
istvanfedak
force-pushed
the
event-stream
branch
2 times, most recently
from
f377d75 to
d3f9ba9
Compare
istvanfedak
force-pushed
the
event-stream
branch
from
d3f9ba9 to
cb51117
Compare
Member
Author
|
These changes look great! I'll publish typescript and express as an |
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.