Fix CI: cppcheck suppressions and optional signing#2
Merged
basmeerman merged 2 commits intomasterfrom Feb 15, 2026
Merged
Conversation
- Add inline cppcheck-suppress comments for style findings in faithfully extracted code (constParameterPointer, variableScope, knownConditionTrueFalse) - Split pio-build.yaml build and signing steps so builds succeed on forks without the SECRET_RSA_KEY signing secret Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
basmeerman
added a commit
that referenced
this pull request
Feb 19, 2026
) Add function-level doc comment and inline section comments throughout http_api_validate_settings() to satisfy CodeQL's poorly-documented-function rule (cpp/poorly-documented-function). Also reorders max_sum_mains_time into the current-limits section (no logic change) and adds boolean-range comments to lcd_lock and cable_lock checks for clarity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
evse_state_machine.c: 4 inlinecppcheck-suppresscommentspio-build.yaml: Split build/sign steps, signing skipped when secret unavailable