Replace hardcoded URLs in strings.json and translation files.#1422
Open
ademuri wants to merge 1 commit intobasnijholt:mainfrom
Open
Replace hardcoded URLs in strings.json and translation files.#1422ademuri wants to merge 1 commit intobasnijholt:mainfrom
ademuri wants to merge 1 commit intobasnijholt:mainfrom
Conversation
This replaces them with placeholders ({webapp_url} and {docs_url}), and
updates config_flow.py to inject these values.
This fixes the "Validate with hassfest" CI action.
homeassilol
approved these changes
Mar 16, 2026
homeassilol
left a comment
homeassilol
left a comment
There was a problem hiding this comment.
Clean change — consistent URL placeholder pattern across all translation files. LGTM.
homeassilol
approved these changes
Mar 17, 2026
homeassilol
left a comment
homeassilol
left a comment
There was a problem hiding this comment.
Clean and consistent — replaces hardcoded URLs with proper constants. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces them with placeholders (
{webapp_url}and{docs_url}), and updatesconfig_flow.pyto inject these values.This fixes the "Validate with hassfest" CI action.