Skip to content

Replace whitespace in file:// with %20 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 3, 2025
Merged

Replace whitespace in file:// with %20 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5915b72
Replace whitespace in `file://` with `%20`
basnijholt Jan 3, 2025
149a378
Fix editable install for whl and zip
basnijholt Jan 3, 2025
e2c5154
Fix typo in test_split_path_and_extras
basnijholt Jan 3, 2025
8125ea2
Use manual replace instead of quote
basnijholt Jan 3, 2025
4d77f2f
use `urllib.request.pathname2url`
basnijholt Jan 3, 2025
d58e8f6
fix import of urllib
basnijholt Jan 3, 2025
7711e0b
fix double `file:`
basnijholt Jan 3, 2025
4eda10e
Add missing //
basnijholt Jan 3, 2025
2dfd6f1
Just use `.replace(" ", "%20")` again
basnijholt Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def test_extract_matching_platforms() -> None:
extract_matching_platforms(incorrect_platform)


def testsplit_path_and_extras() -> None:
def test_split_path_and_extras() -> None:
# parse_with_extras
s = "any/path[something, another]"
path, extras = split_path_and_extras(s)
Expand Down
6 changes: 5 additions & 1 deletion unidep/_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,11 @@ def _pip_install_local(
relative_prefix = ".\\" if os.name == "nt" else "./"
folder = f"{relative_prefix}{folder}" # noqa: PLW2901

if editable:
if (
editable
and not str(folder).endswith(".whl")
and not str(folder).endswith(".zip")
):
pip_command.extend(["-e", str(folder)])
else:
pip_command.append(str(folder))
Expand Down
5 changes: 4 additions & 1 deletion unidep/_setuptools_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ def get_python_dependencies(
for paths in local_dependencies.values():
for path in paths:
name = _package_name_from_path(path)
dependencies.append(f"{name} @ file://{path.as_posix()}")
# TODO: Consider doing this properly using pathname2url # noqa: FIX002
# https://github.com/basnijholt/unidep/pull/214#issuecomment-2568663364
uri = path.as_posix().replace(" ", "%20")
dependencies.append(f"{name} @ file://{uri}")

return Dependencies(dependencies=dependencies, extras=extras)

Expand Down
Loading