Docker compose tiny improvements#1426
Open
yvolchkov wants to merge 1 commit intobassmaster187:masterfrom
Open
Conversation
With this flag container responds way faster to shutdown command
f5428d9 to
3a2638b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign names to containers that need to be accessible from the browseras discussed offline I dropped this commit to preserve compatibility with existing reverse proxy setups.
Just in case, a description of what has been here before is in the quotation block below
add
initflag.Enabling the init flag allows the container to handle and forward signals correctly, which drastically speeds up shutdown times. Here’s what changes:
This improvement occurs because the minimal “init” process (PID 1) inside the container properly manages child processes and signals, preventing long shutdown delays.
Bellow is a demonstration. Notice the timer at the right side of the terminal.