This repository was archived by the owner on Jan 14, 2019. It is now read-only.
Added Milestone Lines to Gantt Chart#13
Open
rfiala wants to merge 1 commit intobastianallgeier:masterfrom
Open
Added Milestone Lines to Gantt Chart#13rfiala wants to merge 1 commit intobastianallgeier:masterfrom
rfiala wants to merge 1 commit intobastianallgeier:masterfrom
Conversation
modified the constructor to accept milestone dates and added a function which draws a line on each milestone date. also removed the whitspaces at the the end of a line which was actually just an accident, but i think it is also useful because of saving bytes :-)
Contributor
|
The commits are a little bit difficult to read because of your whitespace changes. |
|
couldn't figure out how to use the milestones could you update the sample code and help doc. |
|
If you didn't figure it out yet here's an example, arpitnj: $gantti = new Gantti($data, array(
'title' => 'Work List',
'cellwidth' => 25,
'cellheight' => 35,
'milestones' => array('2014-07-23', '2014-07-25')
));Thanks for this extension! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey bastian,
i added a parameter for milestones. i used your library for showing a quick roadmap of features, but what i needed was a marker for milestones over the year. So i modified the constructor to accept milestone dates and added a functionwhich draws a line on each milestone date.
My IDE also removed the whitspaces at the the end of a line which was actually just an accident, but i
think it is also useful because of saving bytes :-).
this is my first pull request so be gentle ;-).
Cheers,
Roland