refactor: composer surface polish, header layout cleanup, and model selector relocation#41
refactor: composer surface polish, header layout cleanup, and model selector relocation#41
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR refactors the composer surface styling to align with ChatGPT's design tokens and consolidates button cursor behavior. The changes improve visual consistency in both light and dark modes while simplifying the component styling hierarchy. Key Changes
All changes are cosmetic refactoring with no functional impact. The CSS tokens are properly defined in Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 9cd9a98 |
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="AGENTS.md">
<violation number="1" location="AGENTS.md:132">
P3: Fix the typo in the new guideline so the documentation reads correctly (“appropriate”).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
AGENTS.md
Outdated
|
|
||
| ## No Timeline Estimates | ||
|
|
||
| **Never include time estimates, durations, or effort assessments** in plans, summaries, or implementation outputs. This includes phrases like "~30 minutes", "2-3 hours", "Phase 1 (Day 1)", "Quick win", or any similar timeline/effort language. AI-generated timeline estimates are unreliable and misleading. Only include difficulty complexity risk estimates when appropiate. |
There was a problem hiding this comment.
P3: Fix the typo in the new guideline so the documentation reads correctly (“appropriate”).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At AGENTS.md, line 132:
<comment>Fix the typo in the new guideline so the documentation reads correctly (“appropriate”).</comment>
<file context>
@@ -127,6 +127,10 @@ When the user asks to "create a prompt" (or similar), return the prompt directly
+## No Timeline Estimates
+
+**Never include time estimates, durations, or effort assessments** in plans, summaries, or implementation outputs. This includes phrases like "~30 minutes", "2-3 hours", "Phase 1 (Day 1)", "Quick win", or any similar timeline/effort language. AI-generated timeline estimates are unreliable and misleading. Only include difficulty complexity risk estimates when appropiate.
+
## Critical Patterns
</file context>
| **Never include time estimates, durations, or effort assessments** in plans, summaries, or implementation outputs. This includes phrases like "~30 minutes", "2-3 hours", "Phase 1 (Day 1)", "Quick win", or any similar timeline/effort language. AI-generated timeline estimates are unreliable and misleading. Only include difficulty complexity risk estimates when appropiate. | |
| **Never include time estimates, durations, or effort assessments** in plans, summaries, or implementation outputs. This includes phrases like "~30 minutes", "2-3 hours", "Phase 1 (Day 1)", "Quick win", or any similar timeline/effort language. AI-generated timeline estimates are unreliable and misleading. Only include difficulty complexity risk estimates when appropriate. |
… up suggestions - Apply shadow-composer and composer-bg tokens to PromptInput instead of generic border/shadow-xs - Use inverted edge shadow strategy (outer dark edge light, inset white glow dark) - Darken --secondary to oklch(0.30) for better contrast - Switch prompt suggestions from outline/ghost to secondary variant - Remove "Writing" suggestion category - Update design token docs with confirmed light/dark shadow details Co-authored-by: Cursor <cursoragent@cursor.com>
…ion styles Move cursor-pointer into the shared button variant so all buttons get it by default. Switch prompt suggestions to ghost variant with hover:bg-secondary for a subtler visual treatment. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
7809bb6 to
9cd9a98
Compare
Summary
cursor-pointerto the shared button base so all buttons get it by defaultComposer & Styling
shadow-composerandcomposer-bgCSS tokens toPromptInputinstead of genericborder/shadow-xs--secondarytooklch(0.30)for better contrast in dark modeoutline/ghosttosecondary/ghostwithhover:bg-secondarycursor-pointerfrom suggestions (now inherited from button base)Header & Layout
stickytofixedpositioningh-svhtoh-dvhModelSelectorHeadercomponent and header-level model selectorMulti-Model State
MultiModelSelectionProvidercontext — localize multi-model selection state intoMultiChatcomponentModelSelectordirectly insideMultiChatInputwith newonSelectedModelIdsChangeproppt-4->pt-20)Cleanup
.agents/plan and skill files superseded on mainTest Plan
bun run lintandbun run typecheckwith no regressions