vpinball: update to support 10.8.1#15238
vpinball: update to support 10.8.1#15238jsm174 wants to merge 1 commit intobatocera-linux:masterfrom
Conversation
| ARCH = x86_64 | ||
| endif | ||
|
|
||
| define VPINBALL_BUILD_BGFX |
There was a problem hiding this comment.
you should add the dependency as a submodule that way you can easily control the version
this is how most other builds work for linux especially
then we can just use VPINBALL_GIT_SUBMODULES = YES
the associated build should then be handled in your cmake files.
There was a problem hiding this comment.
Understood. The vpinball repo does not use submodules so this will not be possible.
https://github.com/vpinball/vpinball/tree/master/platforms/config.sh (contains the shas for external projects)
https://github.com/vpinball/vpinball/tree/master/platforms/* (external build scripts for each platform)
There was a problem hiding this comment.
I've updated the code to pull the BGFX_CMAKE_VERSION and BGFX_PATCH_SHA from the config.sh so they are no longer need in the vpinball.mk.
borrowed $(eval) logic from xemu.mk script.
There was a problem hiding this comment.
why not have the team update it? don't you work with them? you can then add the bgfx build & possible patch to a main cmakelists.txt file then which will include os & architecture detection rather than copying files etc.
bce46db to
6aafdc1
Compare
| ARCH = x86_64 | ||
| endif | ||
|
|
||
| define VPINBALL_BUILD_BGFX |
There was a problem hiding this comment.
why not have the team update it? don't you work with them? you can then add the bgfx build & possible patch to a main cmakelists.txt file then which will include os & architecture detection rather than copying files etc.
|
|
||
| VPINBALL_PRE_CONFIGURE_HOOKS += VPINBALL_BUILD_BGFX | ||
|
|
||
| define VPINBALL_CMAKE_HACKS |
There was a problem hiding this comment.
cmake hacks can also be avoided if they used find_package(PkgConfig) in the associated cmake for third-party libraries also.
328374a to
ce527b7
Compare
ce527b7 to
2069b2f
Compare
This PR is to start the migration of Visual Pinball 10.8.0 to 10.8.1 for Batocera 44.
10.8.1 has been in development for over two years, during which many concepts from the standalone branch were incorporated into master. (Standalone was merged into master on 11/27/2023, and 10.8.1 development started on 12/27/2023)
I'll add additional information here, but a few highlights are:
Other notes: