refactor(configgen): evmapy controller monitor and hotkeygen mouse reset#15386
Open
bryanforbes wants to merge 1 commit intobatocera-linux:masterfrom
Open
refactor(configgen): evmapy controller monitor and hotkeygen mouse reset#15386bryanforbes wants to merge 1 commit intobatocera-linux:masterfrom
bryanforbes wants to merge 1 commit intobatocera-linux:masterfrom
Conversation
Move controller monitoring logic from emulatorlauncher.py into evmapy module as a _ControllerMonitor dataclass, encapsulating thread management, SDL2/pyudev usage, and controller state tracking. The evmapy context manager now returns self and exposes start_monitoring_controllers() for deferred thread startup. Convert hotkeygen's set_hotkeygen_context() generator function into a HotkeygenManager dataclass-based context manager, and move the mouse reset logic into it as reset_mouse(). Remove global mutable state (_active_player_controllers, _evmapy_instance, _player_controllers_lock) and the standalone _controller_monitor_thread/_reconfigure_evmapy_on_the_fly functions from emulatorlauncher.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move controller monitoring logic from emulatorlauncher.py into evmapy module as a _ControllerMonitor dataclass, encapsulating thread management, SDL2/pyudev usage, and controller state tracking. The evmapy context manager now returns self and exposes start_monitoring_controllers() for deferred thread startup.
Convert hotkeygen's set_hotkeygen_context() generator function into a HotkeygenManager dataclass-based context manager, and move the mouse reset logic into it as reset_mouse().
Remove global mutable state (_active_player_controllers, _evmapy_instance, _player_controllers_lock) and the standalone _controller_monitor_thread/_reconfigure_evmapy_on_the_fly functions from emulatorlauncher.py.