refactor(boot): add boot-package macro and use INSTALL_IMAGES#15403
Open
bryanforbes wants to merge 1 commit intobatocera-linux:masterfrom
Open
refactor(boot): add boot-package macro and use INSTALL_IMAGES#15403bryanforbes wants to merge 1 commit intobatocera-linux:masterfrom
bryanforbes wants to merge 1 commit intobatocera-linux:masterfrom
Conversation
bryanforbes
force-pushed
the
refactor/boot-packages
branch
from
1808fb2 to
47d9523
Compare
Introduce `pkg-boot.mk` with a `boot-package` macro that eliminates boilerplate in U-Boot and other boot packages that ship pre-built binaries. Packages declare `_BOOT_SRC` (with optional src:dst rename syntax) and `_BINARIES_SUBDIR`, and the macro handles the rest. Migrate all boot packages from `INSTALL_TARGET_CMDS` to `INSTALL_IMAGES_CMDS` since they install to `$(BINARIES_DIR)`, not `$(TARGET_DIR)`. Convert simple copy-only packages to `boot-package` and manually add `INSTALL_IMAGES = YES` to packages with custom build/install logic. Also refactor `batocera-system` to use `INSTALL_IMAGES_CMDS` for `batocera-boot.conf` and replace hardcoded `BR2_EXTERNAL_BATOCERA_PATH` package paths with `_PKGDIR` throughout.
bryanforbes
force-pushed
the
refactor/boot-packages
branch
from
47d9523 to
b13dc6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
pkg-boot.mkwith aboot-packagemacro that eliminates boilerplate in U-Boot and other boot packages that ship pre-built binaries. Packages declare_BOOT_SRC(with optional src:dst rename syntax) and_BINARIES_SUBDIR, and the macro handles the rest.Migrate all boot packages from
INSTALL_TARGET_CMDStoINSTALL_IMAGES_CMDSsince they install to$(BINARIES_DIR), not$(TARGET_DIR). Convert simple copy-only packages toboot-packageand manually addINSTALL_IMAGES = YESto packages with custom build/install logic.Also refactor
batocera-systemto useINSTALL_IMAGES_CMDSforbatocera-boot.confand replace hardcodedBR2_EXTERNAL_BATOCERA_PATHpackage paths with_PKGDIRthroughout.