feat: forward Bash 5.3's invalid regex error details #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-schulze-vireso
changed the title
martin-schulze-vireso
deleted the
fix/invalid-regex-errors-on-bash-5.3
branch
kozak
reviewed
Oct 11, 2025
| | batslib_decorate "ERROR: ${caller}" \ | ||
| | fail | ||
| return $? | ||
| if (( is_mode_regexp == 1 )) then |
There was a problem hiding this comment.
Don't we need a ; at the end?
Suggested change
| if (( is_mode_regexp == 1 )) then | |
| if (( is_mode_regexp == 1 )); then |
Member
Author
There was a problem hiding this comment.
Good catch, it seems to not be required anymore with bash 5.2 onwards, so it got through the tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix failing tests due to additional output from Bash. This held up development in bats-core due to failing tests in via the
Dockerfile, which is based onbash:latest.