use bats_load_library instead of load and suggest to use BATS_LIB_PATH

[brokenpip3]

No description provided.

[martin-schulze-vireso]

I would not recommend to change the lib path in setup.

[brokenpip3]

I would not recommend to change the lib path in setup.

thanks for the review, you mean only in the brew formula or in general in the instructions for the user?

[martin-schulze-vireso]

I mean in general. The idea of the lib path is to separate system config from the test suite sources. If you hardcode brew paths, what happens when the tests are run in a system without homebrew?

[brokenpip3]

If you hardcode brew paths, what happens when the tests are run in a system without homebrew?

I totally understand your concern but this is a homebrew packages for mac-os users right? I mean -we could but- we never added the linux support to these packages (again it's possible but it will require using brew in linux which is something very few people do for obvious reasons)

Also the BATS_LIB_PATH="${BATS_LIB_PATH}:${HOMEBREW_PREFIX}/lib" will add to an existing BATS_LIB_PATH variable another path that could be even empty or not valid right?

If I have on my bash profile this config in my linux box and I do not have brew installed:

BATS_LIB_PATH="/usr/lib/bats"

and I will use the previous export command with the homebrew prefix the tests will run correctly on both my linux and mac box right?
I'm probably missing something here :)

Anyway I'm totally ok to remove the lib path export, what about keeping the bats_load_library instead of load? should be the preferred way of loading the libraries right?

[brokenpip3]

I created a separated PR to accommodate both file and detik update: #11 and changed the title of this cosmetic one to be threaded a separate change so it can attract more brew users feedback (since I'm not).