Skip to content

Conversation

@vpratz
Copy link
Collaborator

@vpratz vpratz commented Mar 5, 2025

By default, use the latest state instead of the best, as the losses can be unreliable for selecting the best model.

@vpratz vpratz requested a review from stefanradev93 March 5, 2025 18:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/workflows/basic_workflow.py 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
bayesflow/workflows/basic_workflow.py 22.80% <0.00%> (-1.42%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paul-buerkner
Copy link
Contributor

Looks good. You added some other code not related to the change in the title. Was this intentional?

@vpratz
Copy link
Collaborator Author

vpratz commented Mar 7, 2025

Thanks for taking a look. Yes, the changes were intentional and related to checkpoint saving as well (warning if existing checkpoints will be overridden), I forgot to mention them in the text.

@vpratz vpratz force-pushed the doc-basic-workflow-info branch from 7bd6146 to fb39765 Compare March 7, 2025 07:08
@vpratz
Copy link
Collaborator Author

vpratz commented Mar 7, 2025

But looking at it again was good, I found a typo (checkpoint_filepath instead of checkpoint_full_filepath)...

@paul-buerkner
Copy link
Contributor

Looks good from my side. @stefanradev93 do you want to take another look?

@stefanradev93 stefanradev93 merged commit f791a81 into bayesflow-org:dev Mar 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants