-
Notifications
You must be signed in to change notification settings - Fork 78
adapter: support log and sqrt transforms #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
🚀 New features to boost your workflow:
|
LarsKue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! You can just use ElementwiseTransform without filtering for keys manually, this is already implemented by the FilterTransform. You can copy the pattern from AsSet. The ExpandDims transform is also incorrectly implemented.
|
Thanks! That makes sense! |
|
Done. Can you check again @LarsKue ? |
LarsKue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. I think this looks good 👍
|
Great! Merging now. |
This PR adds support for log and sqrt transforms as requested by @stefanradev93.
@LarsKue I noticed that we are using two different patterns to deal with
keysin the adapter. One that uses keys directly in the internal adapter transforms (e.g., expand_dims) and another that loops over the keys inside the mainAdapter(e.g.,as_set). Is this international? If so, when shall we apply which pattern?