Skip to content

Fixed weighted mean everywhere #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 13, 2025
Merged

Fixed weighted mean everywhere #407

merged 14 commits into from
Apr 13, 2025

Conversation

@stefanradev93
Copy link
Contributor

@stefanradev93 stefanradev93 commented Apr 12, 2025

No description provided.

stefanradev93 and others added 14 commits March 25, 2025 19:22
@stefanradev93
Simplify warning
045df8e
@vpratz
Add class for custom transforms to adapter.
2ba93d4 
This commit reintroduces the features that were present in
`LambdaTransform`, but only allowing registered functions. While being
stricter, that allows for closer scaffolding and raising errors early
on, so that users cannot provide functions that will not be
(de)serializable later on.

As there are a few failure modes, the focus is on providing detailed
error messages to enable users to solve problems without external help.
@stefanradev93
Merge branch 'dev' of https://github.com/bayesflow-org/bayesflow into…
d62e73d 
… dev
@vpratz
custom transform: less verbose naming, fix tests
8fdfde9
@vpratz
Merge branch 'dev' into feat-serializable-custom-transform
0591391
@vpratz
Enable integration with fixed, non-uniform schedule.
1c6b90d 
This enables specialized, manually specified schedules, as for example
required in diffusion models for inference.

Closes #402.
@stefanradev93
Uncomment check for torch backend.
18df01c
@vpratz
Merge remote-tracking branch 'upstream/dev' into feat-integration-sch…
be274c1 
…edule
@vpratz
Merge remote-tracking branch 'upstream/dev' into feat-serializable-cu…
630e9cf 
…stom-transform
@vpratz
Merge pull request #399 from vpratz/feat-serializable-custom-transform
33920a2 
Add class for custom transforms to adapter, similar to `LambdaTransform`.
@vpratz
Merge pull request #404 from vpratz/feat-integration-schedule
afc30ba 
Enable integration with fixed, non-uniform schedule.
@vpratz
Merge remote-tracking branch 'upstream/main' into dev
c10d7d3
@stefanradev93
Merge branch 'dev' of https://github.com/bayesflow-org/bayesflow into…
9f11476 
… dev
@stefanradev93
Remove old usage of aggregate and use weighted_mean everywhere
2bf0b53
@codecov
Copy link

codecov bot commented Apr 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.67227% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/utils/integrate.py 64.51% 11 Missing ⚠️
...apters/transforms/serializable_custom_transform.py 89.55% 7 Missing ⚠️
bayesflow/wrappers/mamba/mamba_block.py 0.00% 2 Missing ⚠️
...flow/experimental/free_form_flow/free_form_flow.py 0.00% 1 Missing ⚠️
...w/networks/consistency_models/consistency_model.py 50.00% 1 Missing ⚠️
bayesflow/networks/flow_matching/flow_matching.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/adapters/adapter.py 80.87% <100.00%> (+0.42%) ⬆️
bayesflow/adapters/transforms/__init__.py 100.00% <100.00%> (ø)
bayesflow/networks/coupling_flow/coupling_flow.py 100.00% <100.00%> (ø)
bayesflow/scores/normed_difference_score.py 100.00% <100.00%> (ø)
bayesflow/scores/parametric_distribution_score.py 87.50% <100.00%> (+0.83%) ⬆️
bayesflow/scores/quantile_score.py 100.00% <100.00%> (ø)
bayesflow/scores/scoring_rule.py 93.61% <ø> (-0.51%) ⬇️
bayesflow/utils/__init__.py 100.00% <ø> (ø)
bayesflow/utils/tensor_utils.py 54.74% <100.00%> (ø)
...flow/experimental/free_form_flow/free_form_flow.py 73.87% <0.00%> (ø)
... and 5 more

vpratz
vpratz approved these changes Apr 13, 2025
View reviewed changes
Copy link
Collaborator

@vpratz vpratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the quick fix.

@vpratz vpratz merged commit 25e632c into main Apr 13, 2025
28 checks passed
@vpratz vpratz deleted the dev branch April 13, 2025 11:16
@vpratz vpratz mentioned this pull request Apr 13, 2025
Closed
@vpratz vpratz restored the dev branch April 13, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpratz vpratz vpratz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanradev93 @vpratz