-
Notifications
You must be signed in to change notification settings - Fork 78
Better Loss Plot #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Loss Plot #422
Conversation
Codecov ReportAttention: Patch coverage is
|
LarsKue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I will add the changes that I proposed myself.
Simplified the loss plotting code by consolidating duplication and aligning the handling of smoothing logic. Removed unused arguments like markers and colormap, reducing potential confusion in the API. Updated comments and improved code readability for maintainability.
|
Although it is very pretty, I am removing the gradient line for now, until we have resolved how we can reliably add it to the legend. I also simplified the rest of the code and fixed an issue with the smoothing factor being applied the wrong way around. |
Removed an unnecessary `plt.show()` call in the test to streamline the code. Added a `pytest_runtest_teardown` hook to automatically close all matplotlib figures after tests to prevent resource leaks and improve test isolation.
…numerical density test
Fixed and refined
bf.diagnostics.plots.loss:This version of loss plot also propagates to the
workflowobject.