Fixed Jacobian computation of standardize transform #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y = (x - mu) / sigma log p(y) = log p(x) - log(sigma)
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Kucharssim
approved these changes
May 9, 2025
Member
Kucharssim
left a comment
Kucharssim
left a comment
There was a problem hiding this comment.
Oops, you are right. Thanks for the fix!
Contributor
|
thank you both! feel free to merge :-)
Simon Kucharsky ***@***.***> schrieb am Fr., 9. Mai 2025,
16:42:
… ***@***.**** approved this pull request.
Oops, you are right. Thanks for the fix!
—
Reply to this email directly, view it on GitHub
<#471 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCW2AFGR52ZBSRGZCMQGML25S5GDAVCNFSM6AAAAAB4ZEIGEKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRYGYYTMNRQHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the Jacobian computation of standardize should have reversed sign.
y = (x - mu) / sigma
log p(y) = log p(x) - log(sigma)
Calling the adapter in forward direction should substract log(sigma), while inverse direction should add log(sigma).
Current implementation is switched. The PR fixes that.
BTW: It's really nice that Jacobian tracking adapter exists now in BF, thanks so much!