Skip to content

Fix #506 (missing logits_projector serialization) #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix #506 (missing logits_projector serialization) #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bayesflow/approximators/model_comparison_approximator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ class ModelComparisonApproximator(Approximator):
summary_network: bf.networks.SummaryNetwork, optional
The summary network used for data summarization (default is None).
The input of the summary network is `summary_variables`.
logits_projector: keras.layers.Layer, optional
A layer that projects the output of the classifier network to the logits space for each model.
If not provided, a dense layer with `num_models` units is used by default.
"""

SAMPLE_KEYS = ["summary_variables", "classifier_conditions"]
Expand All @@ -44,14 +47,15 @@ def __init__(
classifier_network: keras.Layer,
adapter: Adapter,
summary_network: SummaryNetwork = None,
logits_projector: keras.layers.Layer = None,
**kwargs,
):
super().__init__(**kwargs)
self.classifier_network = classifier_network
self.adapter = adapter
self.summary_network = summary_network
self.num_models = num_models
self.logits_projector = keras.layers.Dense(num_models)
self.logits_projector = logits_projector if logits_projector is not None else keras.layers.Dense(num_models)

def build(self, data_shapes: Mapping[str, Shape]):
data = {key: keras.ops.zeros(value) for key, value in data_shapes.items()}
Expand Down Expand Up @@ -266,6 +270,7 @@ def get_config(self):
"adapter": self.adapter,
"classifier_network": self.classifier_network,
"summary_network": self.summary_network,
"logits_projector": self.logits_projector,
}

return base_config | serialize(config)
Expand Down