Skip to content

Fix: Add missing standardization calls to Approximator.summarize #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Fix: Add missing standardization calls to Approximator.summarize #581

merged 1 commit into from
Sep 24, 2025

Conversation

@vpratz
Copy link
Collaborator

@vpratz vpratz commented Sep 24, 2025

This PR fixes #580 by adding the required calls to standardize summary_variables. For the ContinuousApproximator, it takes advantage of the existing _prepare_data method.

@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...low/approximators/model_comparison_approximator.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/approximators/continuous_approximator.py 92.89% <100.00%> (ø)
...low/approximators/model_comparison_approximator.py 84.79% <50.00%> (-0.42%) ⬇️

... and 4 files with indirect coverage changes

@stefanradev93 stefanradev93 merged commit e94f836 into dev Sep 24, 2025
8 of 9 checks passed
@stefanradev93 stefanradev93 deleted the fix-standardization-summarize branch September 24, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanradev93 stefanradev93 Awaiting requested review from stefanradev93

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vpratz @stefanradev93