Skip to content

Fix: Add missing standardization calls to Approximator.summarize #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Fix: Add missing standardization calls to Approximator.summarize #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bayesflow/approximators/continuous_approximator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,11 +570,11 @@ def summarize(self, data: Mapping[str, np.ndarray], **kwargs) -> np.ndarray:
if self.summary_network is None:
raise ValueError("A summary network is required to compute summaries.")

data_adapted = self.adapter(data, strict=False, **kwargs)
data_adapted = self._prepare_data(data, **kwargs)
if "summary_variables" not in data_adapted or data_adapted["summary_variables"] is None:
raise ValueError("Summary variables are required to compute summaries.")

summary_variables = keras.tree.map_structure(keras.ops.convert_to_tensor, data_adapted["summary_variables"])
summary_variables = data_adapted["summary_variables"]
summaries = self.summary_network(summary_variables, **filter_kwargs(kwargs, self.summary_network.call))
summaries = keras.ops.convert_to_numpy(summaries)

Expand Down
4 changes: 4 additions & 0 deletions bayesflow/approximators/model_comparison_approximator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,10 @@ def summarize(self, data: Mapping[str, np.ndarray], **kwargs) -> np.ndarray:
raise ValueError("Summary variables are required to compute summaries.")

summary_variables = keras.tree.map_structure(keras.ops.convert_to_tensor, data_adapted["summary_variables"])

if "summary_variables" in self.standardize:
summary_variables = self.standardize_layers["summary_variables"](summary_variables)

summaries = self.summary_network(summary_variables, **filter_kwargs(kwargs, self.summary_network.call))
summaries = keras.ops.convert_to_numpy(summaries)

Expand Down
Loading