fix: Rename targets to work with symbolic macros#1020
Merged
jbedard merged 2 commits intobazel-contrib:mainfrom Jan 13, 2025
Merged
fix: Rename targets to work with symbolic macros#1020jbedard merged 2 commits intobazel-contrib:mainfrom
jbedard merged 2 commits intobazel-contrib:mainfrom
Conversation
dzbarsky
changed the title
jbedard
approved these changes
Jan 7, 2025
auto-merge was automatically disabled
January 11, 2025 18:25
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbolic macros enforce that generated targets begin with macro name, so a symbolic macro wrapping one of these macros would break user code
See See https://bazel.build/extending/macros#naming, these naming conventions are violated by this legacy macro (and thus by a symbolic macro wrapping this legacy macro)
Also fixed the broken stardoc tests while I was here